NamspaceId is tied to PCD Namespace slot logical index

Signed-off-by: Maciej Plucinski <[email protected]>
intel · Oct 24, 2018 · f28a8f7 · f28a8f7
1 parent fe5d0f5
commit f28a8f7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/DcpmPkg/driver/Core/Namespace.c b/DcpmPkg/driver/Core/Namespace.c
@@ -722,9 +722,12 @@ GenerateNamespaceId(
 
   LIST_FOR_EACH(pNode, &gNvmDimmData->PMEMDev.Namespaces) {
     pNamespace = NAMESPACE_FROM_NODE(pNode, NamespaceNode);
-    if (pNamespace->NamespaceId > NamespaceId) {
+    if (pNamespace->NamespaceId == NamespaceId + 1) {
       NamespaceId = pNamespace->NamespaceId;
     }
+    else if (pNamespace->NamespaceId > NamespaceId) {
+      break;
+    }
   }
   NamespaceId++;
   return NamespaceId;
@@ -1970,7 +1973,7 @@ RetrieveNamespacesFromLsa(
 
     pNamespace->Flags.AsUint32 = pNamespaceLabel->Flags.AsUint32;
     pNamespace->Signature = NAMESPACE_SIGNATURE;
-    pNamespace->NamespaceId = GenerateNamespaceId();
+    pNamespace->NamespaceId = (UINT16) Index;
     pNamespace->Enabled = FALSE;
     pNamespace->HealthState = NAMESPACE_HEALTH_OK;
     CopyMem_S(&pNamespace->Name, sizeof(pNamespace->Name), &pNamespaceLabel->Name, NSLABEL_NAME_LEN);

diff --git a/src/os/eventlog/event.c b/src/os/eventlog/event.c
@@ -454,7 +454,7 @@ static char* fgetsrev(char* str, int num, FILE * stream)
     rc = fgets(str, num, stream);
     if (NULL == rc)
         return rc;
-    // Stor information about reached begin of file
+    // Store information about reached begin of file
     if (pos == 0)
     {
         b_o_f = TRUE;