Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: fix outdated information #1986

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

operator: fix outdated information #1986

wants to merge 3 commits into from

Conversation

hj-johannes-lee
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee commented Feb 11, 2025 •
edited
Loading

Closes: #1987

@hj-johannes-lee
operator: remove residue of scorecard
a880b38 
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
@hj-johannes-lee
operator: fix outdated information
c29f898 
update documentation in DEVEL.md too

Signed-off-by: Hyeongju Johannes Lee <[email protected]>
@hj-johannes-lee hj-johannes-lee mentioned this pull request Feb 11, 2025
Closed
22 tasks
mythi
mythi reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for confirmation whether

intel-device-plugins-for-kubernetes/deployments/operator/manifests/bases/intel-device-plugins-operator.clusterserviceversion.yaml

Line 14 in e185665

operators.operatorframework.io/project_layout: go.kubebuilder.io/v2
can be changed too.

@hj-johannes-lee
operator, kubebuilder: update to v4
0ccc20e 
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
@hj-johannes-lee
Copy link
Contributor Author

@mythi Let me.. try..!

@hj-johannes-lee hj-johannes-lee marked this pull request as draft February 18, 2025 14:06
@hj-johannes-lee hj-johannes-lee marked this pull request as ready for review February 18, 2025 14:28
@hj-johannes-lee
Copy link
Contributor Author

@mythi Umm, is PROJECT file in use?

@mythi
Copy link
Contributor

mythi commented Feb 18, 2025

@mythi Umm, is PROJECT file in use?

I don't know what is it for. Won't harm to keep it?

@mythi mythi mentioned this pull request Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythi mythi mythi left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@tkatila tkatila Awaiting requested review from tkatila tkatila is a code owner

@kad kad Awaiting requested review from kad kad is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support go.kubebuilder.io/v4
2 participants
@hj-johannes-lee @mythi