Skip to content

Fix invalid volatile type for glibc 2.35 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Fix invalid volatile type for glibc 2.35 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gstcambasesrc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ static gboolean gst_cam_base_src_send_video_stream_start (GstCamBaseSrc *src, Gs
GType
gst_cam_base_src_get_type (void)
{
static volatile gsize cam_base_src_type = 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this should be rewritten with G_DEFINE_TYPE_WITH_PRIVATE instead.

static gsize cam_base_src_type = 0;

if (g_once_init_enter(&cam_base_src_type)) {
GType _type;
Expand Down
2 changes: 1 addition & 1 deletion src/gstcamerasrcbufferpool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ GType
gst_camerasrc_meta_api_get_type (void)
{
PERF_CAMERA_ATRACE();
static volatile GType type;
static GType type;
static const gchar *tags[] = { "memory", NULL };

if (g_once_init_enter (&type)) {
Expand Down