use 64bit find-and-clear avoiding build failure with GCC14/i386 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilding the Debian package with GCC 14 for the i386 architecture exposes an "incompatible pointer" error, cf. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091572
limex_exceptional.hdefines aFIND_AND_CLEAR_FNmacro that is used onCHUNK_Tpointers in most cases, except inhyperscan/src/nfa/limex_exceptional.h
Line 249 in bc3b191
wordfrom anu64ato aCHUNK_Tat this point but rather use the 64bit-specific find-and-clear function as done in the patch.This fixes the build failure, but I am not sure if this is correct. Please advise on how to test this. Are there any test cases fthat stress this specific code?