This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
[Android] Exclude Wayland dependencies to resolve build errors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4ef3de98d5a557356684f56f5acc7619961d41c0 Signed-off-by: Michele Lim <[email protected]>
shiqiangyu
requested review from
shiqiangyu,
bpscully,
lindongw,
xiaonili and
a team
bpscully
reviewed
Oct 22, 2019
| @@ -1229,6 +1232,7 @@ int32_t PortManager::SetPortProperty( | |||
| return EBUSY; | |||
| } | |||
| } | |||
| #ifndef ANDROID | |||
There was a problem hiding this comment.
Please avoid a #ifndef ANDROID in the port manager. Commit c999be7 made the PortManager class inheritable. Anything specific to one compositor should be moved to the PortManagerHWComposer or PortManager classes.
bpscully
reviewed
Oct 22, 2019
| @@ -271,15 +271,16 @@ int32_t SrmTable::VerifySignature( | |||
| r = BN_bin2bn(pR, DSA_SIG_LENGTH, nullptr); | |||
| s = BN_bin2bn(pS, DSA_SIG_LENGTH, nullptr); | |||
|
|
|||
| if(DSA_SUCCESS != DSA_SIG_set0(sig, r, s)) | |||
| #if OPENSSL_VERSION_NUMBER < 0x10100000L | |||
There was a problem hiding this comment.
Can you just explain a little about why this change is here?
There was a problem hiding this comment.
This function is part of encapsulation under "OPENSSL_VERSION_NUMBER < 0x10100000L) per specification (see line 81), without which the code will not compile.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I4ef3de98d5a557356684f56f5acc7619961d41c0
Signed-off-by: Michele Lim [email protected]