Rename GC_ENABLE_GPU to GC_ENABLE_IMEX & clean up properties usage #205
Conversation
|
Overall LGTM. Do we need GC_ENABLE_GPU in the future, when we introduce non-IMEX GPU features? |
| @@ -1,2 +1,2 @@ | |||
| if not config.gc_use_gpu: | |||
| if not config.gc_use_imex: | |||
There was a problem hiding this comment.
This subdirectory was originally designed for general GPU tests. Shall we rename this directory to IMEX? Or maybe we can add a new subdirectory in test/gc/transforms/GPU/IMEX ?
There was a problem hiding this comment.
Right, so it should either be less strict and allow some of the tests to run. Another option is to split the tests into different folders. Let's decide once we have them.
| @@ -1,2 +1,2 @@ | |||
| if not config.gc_use_gpu: | |||
| if not config.gc_use_imex: | |||
There was a problem hiding this comment.
Similar to above... Do we need to distinguish general GPU tests from IMEX tests?
I don't yet see a need for that unless it steers some runtime dependencies, unavailable on a cpu-only machine. |
This cleans up the gpu passes target and prepares for the default pipeline.