-
Notifications
You must be signed in to change notification settings - Fork 531
fix: Make extraction work for MSI files when unzip and 7zip installed #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
851792a
to
bd3a94d
Compare
3b06e24
to
249f796
Compare
See related bug at #4991 |
249f796
to
0c98a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks promising. I've set the tests to run and I'll be back to do more careful code review when they're passing.
This commit fixes an issue where if both unzip and 7zip were installed, MSI file extraction failed because unzip was attempted first, and failed. Now in the case where both are installed, unzip is tried, and if that fails, then 7zip is tried.
0c98a22
to
588d007
Compare
Hi @terriko, thanks for running tests. I'm a bit confused. When I run the failing tests locally (all except the Windows long tests), I get no errors if I run the tests individually. Specifically, these tests are test_html.py and test_csv2cve.py. However, if I run the full test suite, test_csv2cve.py is failing. However, it's failing on a different line of code to the failure that occurred in the test suite run on the GitHub workflow. This is really strange. I've attached two files; one with the output when the two tests pass when I run them individually, and one with the output when test_csv2cve fails. I don't know if you've seen this before. It looks suspiciously like some kind of environment difference. Anyhow, thanks for taking a look at this. Edit... also note that when I ran the tests individually, I ran them with |
@terriko You can ignore my previous comment. All tests are passing in your CI, so it's irrelevant. |
This commit fixes an issue where if both unzip and 7zip were installed, MSI file extraction failed because unzip was attempted first, and failed.
Now in the case where both are installed, unzip is tried, and if that fails, then 7zip is tried.