refactor: Fixes #4578 #4938
Open
refactor: Fixes #4578 #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unknown or a metrics_id)
terriko
requested changes
Apr 21, 2025
.pre-commit-config.yaml
Outdated
| @@ -26,7 +26,7 @@ repos: | |||
| hooks: | |||
| - id: pyupgrade | |||
| exclude: ^fuzz/generated/ | |||
| args: ["--py38-plus"] | |||
| args: ["--py312-plus"] | |||
There was a problem hiding this comment.
Suggested change
| args: ["--py312-plus"] | |
| args: ["--py39-plus"] |
We actually do want to keep this at py39-plus since we still support python 3.9. This may result in you having to make some other fixes below.
terriko
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Looks like dev-requirements.txt got a bit messed up, probably because this PR is old and there's been some other changes in there (both version bumps and alphabetization), but I don't want to revert a bunch of versions. Can you take that file out of this PR and we'll deal with taking out the < 3.8 stuff some other time? It's either that or rebase and then manually fix it, but I'm pretty sure it'll be easier to just do it separately.
|
Yeah sure thing 👍 |
|
I think it should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed python 3.8 support.
Happy to make any changes if are required.
Thanks