feature: System Allocator support for Level Zero #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: NEO-12988 Signed-off-by: John Falkowski [email protected]
MichalMrozek
reviewed
Dec 6, 2024
| auto alloc = allocData->gpuAllocations.getGraphicsAllocation(device->getRootDeviceIndex()); | ||
| commandContainer.addToResidencyContainer(alloc); | ||
|
|
||
| if (allocData) { |
There was a problem hiding this comment.
this should only be allowed if system shared USM is enabled
| @@ -1140,6 +1144,16 @@ bool Drm::hasPageFaultSupport() const { | |||
| return pageFaultSupported; | |||
| } | |||
|
|
|||
| void Drm::checkSystemAllocEnabled() { | |||
There was a problem hiding this comment.
please change the name to clearly indicate that this is for Shared System USM
| @@ -210,6 +210,7 @@ DECLARE_DEBUG_VARIABLE(int32_t, ForceExtendedUSMBufferSize, -1, "-1: default, 0: | |||
| DECLARE_DEBUG_VARIABLE(int32_t, ForceExtendedKernelIsaSize, -1, "-1: default, 0: disabled, >=1: Forces extended kernel isa size by specified pageSize number") | |||
| DECLARE_DEBUG_VARIABLE(int32_t, ForceSimdMessageSizeInWalker, -1, "-1: default, >=0 Program given value in Walker command for SIMD size") | |||
| DECLARE_DEBUG_VARIABLE(int32_t, EnableRecoverablePageFaults, -1, "-1: default - ignore, 0: disable, 1: enable recoverable page faults on all VMs (on faultable hardware)") | |||
| DECLARE_DEBUG_VARIABLE(int32_t, EnableSystemAllocator, -1, "-1: default - ignore, 0: disable, 1: enable use of system-allocated memory for GPU access") | |||
There was a problem hiding this comment.
please make sure that System Shared USM terminology is used
| return ZE_RESULT_ERROR_INVALID_ARGUMENT; | ||
| DeviceImp *deviceImp = static_cast<DeviceImp *>(device); | ||
| if (!deviceImp->isSystemAllocEnabled()) { | ||
| NEO::SvmAllocationData *allocData = nullptr; |
There was a problem hiding this comment.
why this code is skipped for Shared System USM ?
| vmBind.vmId = static_cast<uint32_t>(ctl.vmId); | ||
| vmBind.flags = DRM_XE_VM_BIND_FLAG_SYSTEM_ALLOCATOR; | ||
| vmBind.handle = 0; | ||
| vmBind.length = (0x1ull << 48); |
There was a problem hiding this comment.
this should be dependant on CPU VA range
| @@ -1317,6 +1320,37 @@ int IoctlHelperXe::xeVmBind(const VmBindParams &vmBindParams, bool isBind) { | |||
| const char *operation = isBind ? "bind" : "unbind"; | |||
| int index = invalidIndex; | |||
|
|
|||
| if (this->drm.isVmBindSystemAlloc()) { | |||
| drm_xe_vm_bind bind = {}; | |||
There was a problem hiding this comment.
why this path is taken for all vm_binds?
this overwrites other ioctl calls, please unify the logic so we have a single ioctl calling point
| @@ -152,6 +152,12 @@ class Drm : public DriverModel { | |||
| void setDirectSubmissionActive(bool value) { this->directSubmissionActive = value; } | |||
| bool isDirectSubmissionActive() const { return this->directSubmissionActive; } | |||
|
|
|||
| void setVmBindSystemAlloc(bool value) { this->vmBindSystemAlloc = value; } | |||
There was a problem hiding this comment.
please remove, this needs to be passed via arguments and not by modyfing global drm state.
| @@ -152,6 +152,12 @@ class Drm : public DriverModel { | |||
| void setDirectSubmissionActive(bool value) { this->directSubmissionActive = value; } | |||
| bool isDirectSubmissionActive() const { return this->directSubmissionActive; } | |||
|
|
|||
| void setVmBindSystemAlloc(bool value) { this->vmBindSystemAlloc = value; } | |||
| bool isVmBindSystemAlloc() const { return this->vmBindSystemAlloc; } | |||
There was a problem hiding this comment.
please remove and pass via arguments
| } | ||
| bind.bind.obj = 0; | ||
| //if (bindInfo[index].userptr) { |
There was a problem hiding this comment.
please remove commented code
Related-To: NEO-12988 Signed-off-by: John Falkowski [email protected] Signed-off-by: Falkowski, John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: NEO-12988
Signed-off-by: John Falkowski [email protected]