Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[offline_compiler/tests] Add -lexecinfo to resolve backtrace and backtrace_symbols #330

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

krupenik
Copy link

No description provided.

@krupenik krupenik changed the title [ocloc_tests] Add -lexecinfo to resolve backtrace and backtrace_symbols [offline_compiler/tests] Add -lexecinfo to resolve backtrace and backtrace_symbols Jun 20, 2020
@JacekDanecki
Copy link
Contributor

I don't think libexecinfo library is available in Linux distributions used by Neo CI. It's only available on Alpine and few other distros, see: https://repology.org/project/libexecinfo/versions
If you want to make specific changes for Alpine, you can modify function get_os_release_info and add support for Alpine, and then use it in cmake file similar like in package.cmake

@krupenik
Copy link
Author

I don't think libexecinfo library is available in Linux distributions used by Neo CI. It's only available on Alpine and few other distros, see: https://repology.org/project/libexecinfo/versions
If you want to make specific changes for Alpine, you can modify function get_os_release_info and add support for Alpine, and then use it in cmake file similar like in package.cmake

thanks, looking into it

@krupenik
Copy link
Author

@JacekDanecki what's your preferred approach, scope -lexecinfo to Alpine/Adelie or replace with libunwind (https://repology.org/project/libunwind/versions)?

@JacekDanecki
Copy link
Contributor

I'd prefer preparation changes specific for Alpine, as it'll not have impact on binaries created for another distributions. libunwind is interesting proposal, but using it we could add some old bugs to Neo code, as for example: libunwind/libunwind#94. This was fixed in libunwind 1.5-rc2, which is not available in all distributions yet.

@JablonskiMateusz
Copy link
Contributor

@krupenik could you confirm if it is still needed?

@krupenik
Copy link
Author

krupenik commented Jun 30, 2022

@krupenik could you confirm if it is still needed?

to the best of my knowledge — yes, for non-glibc builds it is still needed.

@JablonskiMateusz
Copy link
Contributor

@krupenik could you confirm if it is still needed?

to the best of my knowledge — yes, for non-glibc builds it is still needed.

Could you detect the need on cmake level? based on some package detection add this execinfo dependency

@krupenik
Copy link
Author

krupenik commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants