qatzip_lz4: function declaration without a prototype for qzLZ4HeaderSz #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On modern compilers it becomes a compilation error with message: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] Signed-off-by: Kyr Shatskyy <[email protected]>
|
hello @kshtsk, Very thanks for your PR, Could you please share the detailed info of modern compilers? do you using the high version gcc compiler or clang compiler, we want to update our STV compiler, so we could capture those compiler issue |
I am using clang-17 recently to reproduce this: |
|
hello @kshtsk, thanks we have already fixed it in internal repo, will upstream those fixs in next release around Q4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On modern compilers it becomes a compilation error with message:
error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]