Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build perf with support for bpf #117

Merged
merged 2 commits into from
Dec 10, 2024
Merged

build perf with support for bpf #117

merged 2 commits into from
Dec 10, 2024

Conversation

harp-intel
Copy link
Contributor

bpf is required for new lock analysis functionality in the 'lock' command

This PR makes the required changes to the build image. The base image is moved to Ubuntu 22.04, so need to run tests across array of OS to verify compatibility.

@harp-intel
Copy link
Contributor Author

harp-intel commented Dec 10, 2024

Tests on OS's with older GLIBC are failing when using Ubuntu 22.04 as a base image.

Considering alternatives, e.g., perf as a pre-requisite on target systems for the 'metrics', 'flame', and 'lock' commands.

tools/build.Dockerfile Outdated Show resolved Hide resolved
@TianyouLi
Copy link
Contributor

Thanks @harp-intel , i will close my PR-116 accordingly:)

@harp-intel
Copy link
Contributor Author

@TianyouLi I will attempt to build perf in a separate Dockerfile stage than the rest of the tools. This will (should) fix the compatibility issue with older OS distributions (older GLIBC).

@harp-intel harp-intel merged commit 70d79cd into main Dec 10, 2024
4 checks passed
@harp-intel harp-intel deleted the perfwithbpf branch December 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants