Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue for make dist: once the internal/resources directory contains no files, //go:embed will be invalid #107

Closed
wants to merge 1 commit into from

Conversation

TianyouLi
Copy link
Contributor

Problem

When build as 'make dist', it will report errors like below:

   internal/script/script.go:21:3: invalid go:embed: build system did not supply embed configuration (compile)
   internal/script/script.go:21:12: pattern resources: cannot embed directory resources: contains no embeddable files (compile)
   make: *** [Makefile:90: check_static] Error 1

Proposed Solution

Check if the resources/x64 directory is empty, if yes, just touch a empty file to workaround the go compilation error

@TianyouLi TianyouLi requested a review from harp-intel as a code owner December 3, 2024 07:21
@harp-intel
Copy link
Contributor

Prefer that build fails when binaries are not present. The binaries are required for perfspect to operate properly.

@harp-intel harp-intel closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants