Merge pull request #128 from intel/reportalltrue

perfspect report flag 'all' is true by default
intel · Dec 19, 2024 · 4fcd5f7 · 4fcd5f7
2 parents 73961ae + 6b16cb2
commit 4fcd5f7
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/cmd/report/report.go b/cmd/report/report.go
@@ -182,7 +182,7 @@ func init() {
 	}
 	// set up other flags
 	Cmd.Flags().StringVar(&common.FlagInput, common.FlagInputName, "", "")
-	Cmd.Flags().BoolVar(&flagAll, flagAllName, false, "")
+	Cmd.Flags().BoolVar(&flagAll, flagAllName, true, "")
 	Cmd.Flags().StringSliceVar(&common.FlagFormat, common.FlagFormatName, []string{report.FormatAll}, "")
 	Cmd.Flags().StringSliceVar(&flagBenchmark, flagBenchmarkName, []string{}, "")
 
@@ -263,18 +263,14 @@ func getFlagGroups() []common.FlagGroup {
 }
 
 func validateFlags(cmd *cobra.Command, args []string) error {
-	// set flagAll if all categories are selected or if none are selected
-	if !flagAll {
-		numCategoriesTrue := 0
+	// clear flagAll if any categories are selected
+	if flagAll {
 		for _, cat := range categories {
-			if *cat.FlagVar {
-				numCategoriesTrue++
+			if cat.FlagVar != nil && *cat.FlagVar {
+				flagAll = false
 				break
 			}
 		}
-		if numCategoriesTrue == len(categories) || numCategoriesTrue == 0 {
-			flagAll = true
-		}
 	}
 	// validate format options
 	for _, format := range common.FlagFormat {