-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(returner): add new type #20
Conversation
Generated |
Unit Test Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I've also requested @dominikkadera review just to have a look whether we are not forgetting something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping -- looks great to me as well 👌
One small detail I'd probably suggest is expanding the Legacy Compatibility Test -- https://github.com/integromat/imt-proto/blob/63bebd88c9653c18d470242b81293b5b2e0507c1/test/legacy-compatibility.test.ts -- to cover also for the Returner. If I remember correctly, there are still Services (for example the WebAPI), which use the @integromat/proto/global
implementation, and therefore adding a test which ensures that the global.IMTReturner
is indeed set correctly could be a good safety-net costing us just a couple of more lines of a test code 🙏
From technical point of view, I'd say all the needs are covered 😁
Thank you all for review 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the tweaks, looks perfect now 👌 🚀
https://make.atlassian.net/browse/CDM-13296
add new
returner
type to proto libthis type will be used to return data from scenarios