Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(returner): add new type #20

Merged
merged 3 commits into from
Feb 10, 2025
Merged

feat(returner): add new type #20

merged 3 commits into from
Feb 10, 2025

Conversation

ivangelus
Copy link
Contributor

@ivangelus ivangelus commented Feb 7, 2025

https://make.atlassian.net/browse/CDM-13296

add new returner type to proto lib

this type will be used to return data from scenarios

Copy link

github-actions bot commented Feb 7, 2025

Messages
Your PR title & description are valid

Generated 8. 2. 2025 12:03:12 GMT+1 for 2eaecb3

@make-coverage
Copy link

make-coverage bot commented Feb 7, 2025

Unit Test Coverage Report

Metric master CDM-13296-returner-type Status
Statements 85.13% 84.85% 💔
Branches 45.35% 45.35% ✔️
Functions 64.86% 64.60% 💔

Copy link
Contributor

@matejmichnak matejmichnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I've also requested @dominikkadera review just to have a look whether we are not forgetting something.

Copy link
Member

@dominikkadera dominikkadera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping -- looks great to me as well 👌

One small detail I'd probably suggest is expanding the Legacy Compatibility Test -- https://github.com/integromat/imt-proto/blob/63bebd88c9653c18d470242b81293b5b2e0507c1/test/legacy-compatibility.test.ts -- to cover also for the Returner. If I remember correctly, there are still Services (for example the WebAPI), which use the @integromat/proto/global implementation, and therefore adding a test which ensures that the global.IMTReturner is indeed set correctly could be a good safety-net costing us just a couple of more lines of a test code 🙏

From technical point of view, I'd say all the needs are covered 😁

@ivangelus ivangelus marked this pull request as ready for review February 8, 2025 11:04
@ivangelus ivangelus requested a review from a team as a code owner February 8, 2025 11:04
@ivangelus
Copy link
Contributor Author

Thank you all for review 🙏
extended legacy comp test 👍

Copy link
Member

@dominikkadera dominikkadera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the tweaks, looks perfect now 👌 🚀

@ivangelus ivangelus merged commit 1159d95 into master Feb 10, 2025
3 checks passed
@ivangelus ivangelus deleted the CDM-13296-returner-type branch February 10, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants