Add method declarations and implementations to UnitLevelKeywordIndentation rule #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cirras
requested changes
Oct 17, 2023
There was a problem hiding this comment.
I agree with the logic changes, but I don't agree with the new wording.
That is, I have a fairly strict definition of what a "statement" is, and a method or type declaration doesn't fit it.
Naming/wording is hard, any thoughts on alternatives for the issue message & rule description?
|
"Unindent this top-level construct?" |
|
"construct" feels odd. "element" maybe...? |
fourls
force-pushed
the
add-procedure-to-indent-check
branch
from
1f71415
to
f28526b
Compare
|
I've updated to "Unindent this top-level element." |
Cirras
requested changes
Oct 19, 2023
.../test/resources/au/com/integradev/delphi/checks/UnitLevelKeywordIndentationCheck/Correct.pas
Show resolved
Hide resolved
Cirras
force-pushed
the
add-procedure-to-indent-check
branch
from
1fffb2f
to
2f5b745
Compare
Cirras
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the UnitLevelKeywordIndentation rule to also pick up unindented:
beginandendkeywords for method implementationsTo reflect that it is now handling more than just single keywords, the message has also been changed to "Unindent this top-level statement."