Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add architecture tests for test classes and methods #295

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add architecture tests for test classes and methods #295

merged 1 commit into from
Oct 4, 2024

Conversation

jgardn3r
Copy link
Collaborator

It is common for a test name not to represent what it is asserting. An example of this is a test named ...ShouldAddIssue calling verifyNoIssues.

This PR adds some architecture tests targeting checks that assert:

  • Test names are accurate to the assertion
  • All checks have test units
  • All test units have an associated check

Cirras
Cirras requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks.
Most of them are just removing FalsePositive from test names.

delphi-checks/src/test/java/au/com/integradev/delphi/checks/BeginEndRequiredCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/CheckTestNameTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/ClassPerFileCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/ClassPerFileCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/EmptyRoutineCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/TypeAliasCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/TypeAliasCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/TypeAliasCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/TypeAliasCheckTest.java Outdated Show resolved Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/TypeAliasCheckTest.java Outdated Show resolved Hide resolved
@jgardn3r jgardn3r requested a review from Cirras October 4, 2024 01:11
Cirras
Cirras approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🎉

@Cirras Cirras merged commit 2ec51a3 into master Oct 4, 2024
2 checks passed
@Cirras Cirras deleted the testArchTests branch October 4, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cirras Cirras Cirras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgardn3r @Cirras