Exclude dpr and dpk imports in LineTooLong

integrated-application-development · Oct 16, 2023 · 12ee42d · 12ee42d
1 parent ae9c752
commit 12ee42d
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Clean up descriptions of all plugin properties.
 - Exclude dpr and dpk files in `UnusedImport`.
 - Exclude dpr and dpk files in `ImportSpecificity`.
+- Exclude uses clauses of dpr and dpk files in `LineTooLong`.
 - Improve name resolution for declarations within types.
 - Improve type resolution for array accesses into variants.
 - Improve parsing and type modeling around `AnsiString` types with specified code pages.

diff --git a/delphi-checks/src/main/java/au/com/integradev/delphi/checks/TooLongLineCheck.java b/delphi-checks/src/main/java/au/com/integradev/delphi/checks/TooLongLineCheck.java
@@ -18,9 +18,11 @@
  */
 package au.com.integradev.delphi.checks;
 
+import java.util.function.IntPredicate;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
 import org.sonar.plugins.communitydelphi.api.ast.DelphiAst;
+import org.sonar.plugins.communitydelphi.api.ast.UsesClauseNode;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheck;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheckContext;
 import org.sonar.plugins.communitydelphi.api.check.FilePosition;
@@ -39,7 +41,13 @@ public class TooLongLineCheck extends DelphiCheck {
 
   @Override
   public DelphiCheckContext visit(DelphiAst ast, DelphiCheckContext context) {
+    IntPredicate isLineExcluded = getLineExclusionFilter(ast);
+
     for (int i = 0; i < context.getFileLines().size(); ++i) {
+      if (isLineExcluded.test(i)) {
+        continue;
+      }
+
       String line = context.getFileLines().get(i);
       int lineLength = getLineLength(line);
 
@@ -55,9 +63,20 @@ public DelphiCheckContext visit(DelphiAst ast, DelphiCheckContext context) {
             .report();
       }
     }
+
     return context;
   }
 
+  private static IntPredicate getLineExclusionFilter(DelphiAst ast) {
+    if (ast.isPackage() || ast.isProgram()) {
+      UsesClauseNode usesClause = ast.getFirstChildOfType(UsesClauseNode.class);
+      if (usesClause != null) {
+        return line -> usesClause.getBeginLine() <= line && usesClause.getEndLine() >= line;
+      }
+    }
+    return line -> false;
+  }
+
   private static int getLineLength(String line) {
     int length = line.length();
 

diff --git a/delphi-checks/src/test/java/au/com/integradev/delphi/checks/TooLongLineCheckTest.java b/delphi-checks/src/test/java/au/com/integradev/delphi/checks/TooLongLineCheckTest.java
@@ -18,6 +18,7 @@
  */
 package au.com.integradev.delphi.checks;
 
+import au.com.integradev.delphi.builders.DelphiTestProgramBuilder;
 import au.com.integradev.delphi.builders.DelphiTestUnitBuilder;
 import au.com.integradev.delphi.checks.verifier.CheckVerifier;
 import org.junit.jupiter.api.Test;
@@ -66,4 +67,18 @@ void testTrailingWhitespaceLineShouldNotAddIssue() {
                 .appendImpl("end;"))
         .verifyNoIssues();
   }
+
+  @Test
+  void testProgramImportShouldNotAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new TooLongLineCheck())
+        .onFile(
+            new DelphiTestProgramBuilder()
+                .appendDecl("uses")
+                .appendDecl(
+                    "  Fooooooooooooooooooooooooooooooooooooooooooooooooo"
+                        + ".Baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar"
+                        + ".Baaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaz;"))
+        .verifyNoIssues();
+  }
 }