-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement quick fixes #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased on latest master, ready for review ✔️ |
Cirras
requested changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! A few small points of feedback.
...er/delphilint-server/src/main/java/au/com/integradev/delphilint/analysis/DelphiQuickFix.java
Outdated
Show resolved
Hide resolved
...er/delphilint-server/src/main/java/au/com/integradev/delphilint/analysis/DelphiQuickFix.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/au/com/integradev/delphilint/server/message/ResponseAnalyzeResult.java
Outdated
Show resolved
Hide resolved
...lint-server/src/main/java/au/com/integradev/delphilint/server/message/data/QuickFixData.java
Outdated
Show resolved
Hide resolved
fourls
force-pushed
the
quickfix
branch
2 times, most recently
from
May 9, 2024 06:50
0738848
to
e062e22
Compare
Cirras
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of integrated-application-development/sonar-delphi#215 and release 1.5.0, SonarDelphi outputs automated fixes in a number of cases.
This PR adds support for applying these quick fixes in two ways: via right click on the issue range, and via right click on the issue entry.
One quick fix:
Multiple quick fixes: