Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement quick fixes #30

Merged
merged 5 commits into from
May 9, 2024
Merged

Implement quick fixes #30

merged 5 commits into from
May 9, 2024

Conversation

fourls
Copy link
Collaborator

@fourls fourls commented May 7, 2024

As of integrated-application-development/sonar-delphi#215 and release 1.5.0, SonarDelphi outputs automated fixes in a number of cases.

This PR adds support for applying these quick fixes in two ways: via right click on the issue range, and via right click on the issue entry.

One quick fix:

image

image

Multiple quick fixes:

image

image

@fourls fourls changed the title Quickfix Implement quick fixes May 7, 2024
@fourls fourls marked this pull request as ready for review May 9, 2024 02:08
@fourls
Copy link
Collaborator Author

fourls commented May 9, 2024

Rebased on latest master, ready for review ✔️

@fourls fourls requested a review from Cirras May 9, 2024 02:09
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A few small points of feedback.

@fourls fourls force-pushed the quickfix branch 2 times, most recently from 0738848 to e062e22 Compare May 9, 2024 06:50
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@Cirras Cirras merged commit 062da45 into master May 9, 2024
4 checks passed
@Cirras Cirras deleted the quickfix branch May 9, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants