Disable project options save when URL/token is blank

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+* Project Options now prevents a blank server URL or project key when in Connected Mode.
+
 ### Fixed
 
 * Incompatibility with SonarQube 9.9, by using the HTTP Basic authentication scheme instead of the Bearer scheme.

client/source/DelphiLint.OptionsForm.dfm

@@ -67,9 +67,9 @@ object LintOptionsForm: TLintOptionsForm
         Width = 234
         Height = 23
         Anchors = [akLeft, akTop, akRight]
-        EditLabel.Width = 56
+        EditLabel.Width = 61
         EditLabel.Height = 15
-        EditLabel.Caption = 'Server URL'
+        EditLabel.Caption = 'Server URL*'
         TabOrder = 0
         Text = ''
         OnChange = SonarHostUrlEditChange
@@ -93,9 +93,9 @@ object LintOptionsForm: TLintOptionsForm
         Width = 234
         Height = 23
         Anchors = [akLeft, akTop, akRight]
-        EditLabel.Width = 58
+        EditLabel.Width = 63
         EditLabel.Height = 15
-        EditLabel.Caption = 'Project key'
+        EditLabel.Caption = 'Project key*'
         TabOrder = 1
         Text = ''
         OnChange = SonarHostProjectKeyEditChange

client/source/DelphiLint.OptionsForm.pas

@@ -74,6 +74,7 @@   TLintOptionsForm = class(TForm)
 
     procedure UpdateControls;
     procedure UpdateTokenInfo;
+    function Validate: Boolean;
   public
     procedure RefreshOptions;
     procedure RefreshTheme;
@@ -137,7 +138,6 @@ procedure TLintOptionsForm.UpdateControls;
     SonarHostDownloadPluginCheckBox.Checked := FProjectOptions.SonarHostDownloadPlugin;
     AnalysisBaseDirEdit.Text := FProjectOptions.AnalysisBaseDir;
     AnalysisReadPropertiesCheckBox.Checked := FProjectOptions.AnalysisReadProperties;
-    SaveButton.Enabled := True;
 
     ProjectName := TPath.GetFileName(FProjectFile);
     ProjectNameLabel.Caption := 'DelphiLint: ' + ProjectName;
@@ -149,12 +149,12 @@ procedure TLintOptionsForm.UpdateControls;
     SonarHostDownloadPluginCheckBox.Checked := False;
     AnalysisBaseDirEdit.Text := '';
     AnalysisReadPropertiesCheckBox.Checked := False;
-    SaveButton.Enabled := False;
 
     ProjectNameLabel.Caption := 'DelphiLint: (no project)';
     Caption := 'DelphiLint Project Options (no project)';
   end;
 
+  SaveButton.Enabled := Validate;
   UpdateTokenInfo;
 end;
 
@@ -242,6 +242,7 @@ procedure TLintOptionsForm.SonarHostUrlEditChange(Sender: TObject);
     FProjectOptions.SonarHostUrl := SonarHostUrlEdit.Text;
     UpdateTokenInfo;
   end;
+  SaveButton.Enabled := Validate;
 end;
 
 //______________________________________________________________________________________________________________________
@@ -261,6 +262,7 @@ procedure TLintOptionsForm.SonarHostProjectKeyEditChange(Sender: TObject);
   if Assigned(FProjectOptions) then begin
     FProjectOptions.SonarHostProjectKey := SonarHostProjectKeyEdit.Text;
   end;
+  SaveButton.Enabled := Validate;
 end;
 
 //______________________________________________________________________________________________________________________
@@ -324,4 +326,16 @@ procedure TLintOptionsForm.UpdateTokenInfo;
 
 //______________________________________________________________________________________________________________________
 
+function TLintOptionsForm.Validate: Boolean;
+begin
+  if IsConnectedMode then begin
+    Result := (SonarHostUrlEdit.Text <> '') and (SonarHostProjectKeyEdit.Text <> '');
+  end
+  else begin
+    Result := True;
+  end;
+end;
+
+//______________________________________________________________________________________________________________________
+
 end.