Chore: Apple notarization flow #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit c39fce1): https://grid-editor-web--pr902-chore-apple-notariza-m60825fm.web.app (expires Fri, 24 Jan 2025 13:41:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f |
|
@danim1130 please review and merge if all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Googled a lot aboutUnexpexted error ... JSON...and found similar issues, all related to authentication issues.2. Bumpedelectron-builderto the last version in24major. This was needed to confirm the issue more easily. We should update both electron, node and electron-builder soon.3. Removedelectron/notarizepackage as we do not use separate sign script, but electron-builder directly.4. Issue was that theAPPLE_APP_SPECIFIC_PASSWORDin github secrets was invalid. This password is automatically revoked when the related apple_id password is reset. I could not login to my apple account due to some issue with apple itself, so had to recreate my password. After securing my own account, had to re-create the app specific password.5. An other issue seemed to me that the APPLE_TEAM_ID was invalid, but could not confirm it. Updated it anyway.Basically now all recently failed runs can be re-run.Sporadic issue, impacting other projects as well. Based on recent suggestions from others, added a retry script.