add options for SDSC and EC2 patchers #937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1o0
reviewed
Feb 20, 2025
| task.session_path = SDSC_TMP.joinpath(session_path) | ||
| assert self.getOutputFiles(session_path=task.session_path).shape[0] == 0, ( | ||
| "On SDSC patcher, input files output files should be distinct from input files to avoid overwriting") |
There was a problem hiding this comment.
Minor typo here. Also could you please add a comment about copying input files that are also output file in the future? Otherwise if we encounter this assertion in the future we may not remember the implications of breaking it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the patching of the wheel data, I needed some more control of patching using EC2 and SDSC.
task.run(hash_files=False)