Skip to content

add options for SDSC and EC2 patchers #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

add options for SDSC and EC2 patchers #937

merged 5 commits into from
Jun 17, 2025

Conversation

oliche
Copy link
Member

@oliche oliche commented Feb 19, 2025

During the patching of the wheel data, I needed some more control of patching using EC2 and SDSC.

  • SDSC patcher operates on symlinks, and if one of the input files is modified, this directly impacts the original data. I have set an assertion that enforces distinct input and output datasets
  • the EC2 patcher didn't check file hashes on checking local data, I've set it to true by default and provided an option to opt-out for bulky input data such as spike sorting. task.run(hash_files=False)

@oliche oliche requested a review from mayofaulkner February 19, 2025 12:48
@k1o0 k1o0 self-assigned this Jun 16, 2025
oliche and others added 5 commits June 16, 2025 18:11
Force is passed down through many chained method calls to registration. Clobber doesn't currently do anything and renaming must be done with care as the it's an important kwarg used in a lot of ad hoc code
@k1o0 k1o0 merged commit c629aae into develop Jun 17, 2025
4 of 6 checks passed
@k1o0 k1o0 deleted the patcher branch June 17, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants