Sleep before nacking (#22)

Co-authored-by: Axel Hellström <[email protected]>
Co-authored-by: Frida Jakobsson <[email protected]>

.circleci/config.yml

@@ -1,8 +1,8 @@
 version: 2.0
 jobs:
   build:
-    machine:
-        enabled: true
+    docker:
+      - image: circleci/node:12
     working_directory: ~/insurello
     steps:
       - checkout

.gitignore

@@ -1,4 +1,3 @@
 node_modules/
-package-lock.json
 src/*.js
 dist/test

.mocharc.json

@@ -0,0 +1,5 @@
+{
+  "extension": ["ts"],
+  "spec": "test/*_test.ts",
+  "require": "ts-node/register"
+}

.prettierignore

@@ -0,0 +1 @@
+dist

.prettierrc.json

@@ -0,0 +1 @@
+{}

Makefile

@@ -10,7 +10,7 @@ build: $(SRC)
 	$(BIN)/tsc --outDir dist --project . --pretty --declaration
 
 lint: $(SRC)
-	$(BIN)/prettier -l $(SRC) $(TEST)
+	$(BIN)/prettier --check .
 	$(BIN)/tslint --project . --format codeFrame
 
 format: $(SRC)

README.md

@@ -36,13 +36,13 @@ If the `event` field is a string instead of a callback function it is interprete
 ```typescript
 mq.events({
   type: commit.decoder,
-  init: options => ({}),
+  init: (options) => ({}),
   event: "event",
   events: {
     claim: (commit: Commit, context) => Promise.resolve(),
     closed: (commit: Commit, context) => Promise.resolve(),
-    rejected: (commit: Commit, context) => Promise.resolve()
-  }
+    rejected: (commit: Commit, context) => Promise.resolve(),
+  },
 });
 ```
 
@@ -56,10 +56,10 @@ import * as t from "io-ts";
 
 const helloWorld = mq.service({
   type: t.type({ message: t.string }),
-  init: options => ({}),
+  init: (options) => ({}),
   authorized: (headers, context) => Promise.resolve(context),
   forbidden: (headers, context) => Promise.resolve(context),
-  response: context => Promise.resolve({ message: "Hello World!" })
+  response: (context) => Promise.resolve({ message: "Hello World!" }),
 });
 ```
 
@@ -81,3 +81,11 @@ const helloName = mq.resource({
   response: context => Promise.resolve({ message: `Hello ${context.name}!`` })
 });
 ```
+
+## Nack delay
+
+By default, all handler types sleep for 30 seconds before nacking, to reduce the number of errors reported.
+
+You can pass for example `defaultNackDelayMs: 10000` to `mq.events`, `mq.service` and `mq.resource` to change the default nack delay.
+
+You can also set `.nackDelayMs = 0` on specific `Error`s to set a different delay for a certain error.

dist/src/errors.d.ts

@@ -1,6 +1,7 @@
+import { Logger } from "./logger";
 import { Request } from "./request";
 export interface ErrorDescription {
     error: string;
     error_description: string;
 }
-export declare const errorHandler: (req: Request, logger: import("winston").Logger) => (err?: unknown) => void;
+export declare const errorHandler: (req: Request, logger: Logger, defaultDelayMs?: number) => (err?: unknown) => Promise<void>;

dist/src/events.d.ts

@@ -8,6 +8,7 @@ interface SingleCallbackStyle<T, C, O> {
     init: (options: any) => PromiseLike<C> | C;
     event: Callback<T, C>;
     logger?: Logger;
+    defaultNackDelayMs?: number;
 }
 interface EventCallbackStyle<T, C, O> {
     type: t.Type<T, O>;
@@ -17,6 +18,7 @@ interface EventCallbackStyle<T, C, O> {
         [key: string]: Callback<T, C>;
     };
     logger?: Logger;
+    defaultNackDelayMs?: number;
 }
 export declare const events: <T, C = any, O = T>(desc: Events<T, C, O>) => (options: any) => (req: Request) => Promise<void>;
 export {};

dist/src/resource.d.ts

@@ -10,5 +10,6 @@ export interface Resource<T, U, C, TO, UO> {
     update: (data: T, context: C) => PromiseLike<C> | C;
     response: (context: C) => PromiseLike<U> | U;
     logger?: Logger;
+    defaultNackDelayMs?: number;
 }
 export declare const resource: <T, U = unknown, C = any, TO = T, UO = U>(desc: Resource<T, U, C, TO, UO>) => (options: any) => (req: Request) => Promise<void>;