Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-view,ui-file-drop,ui-buttons): make focus ring radius fit the … #1868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Feb 12, 2025

…enclosed element's radius

INSTUI-4375

ISSUE: When a border radius in a Button or FileDrop component is modified, the focus ring radius does not follow.

TEST PLAN:

  • test the examples in Button, BaseButton, IconButton, CondensedButton and FileDrop if the focus ring radius will follow the border radius override:
themeOverride={{
    borderRadius: '100px'
  }}
  • the examples's focus ring should work as expected without the override

Copy link

PR Preview Action v1.6.0

🚀 View preview at
https://instructure.github.io/instructure-ui/pr-preview/pr-1868/

Built to branch gh-pages at 2025-02-12 14:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa self-assigned this Feb 12, 2025
@ToMESSKa ToMESSKa requested review from balzss and matyasf February 13, 2025 08:05
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants