docs(ui-date-time-input): fix Calendar and DateTimeInput page examples clipped off in docs #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s clipped off in docs This fix makes margins much smaller in small viewports, so pages look much better. This fixes Calendar examples being clipped off INSTUI-4256
matyasf
commented
Feb 4, 2025
| @@ -824,6 +821,9 @@ class App extends Component<AppProps, AppState> { | |||
| <div css={this.props.styles?.hamburger}> | |||
| <InstUISettingsProvider> | |||
| <IconButton | |||
| themeOverride={{ | |||
| secondaryBorderColor: '#343434' | |||
| }} | |||
There was a problem hiding this comment.
Now the hamburger menu is overlapping the content, so I made its border have a bit more contrast
There was a problem hiding this comment.
Did the designers agree to make this change?
There was a problem hiding this comment.
They dont have to agree on smaller changes in our docs app :)
|
git-nandor
approved these changes
Feb 5, 2025
joyenjoyer
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes margins much smaller in small viewports, so pages look much better. This fixes Calendar examples being clipped off.
To test check out the DateTimeInput and Calendar pages in docs with width set to 320px via devtools.
closes: INSTUI-4256