Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ui-stylelint-config, update dependecies #1707

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

matyasf
Copy link
Collaborator

@matyasf matyasf commented Sep 30, 2024

Remove ui-stylelint-config because:

  • It was used to lint .css files, which is kinda useless by itself because we only have a few .css files and most of them are autogenerated.
  • It was not invoked by our lint command because we did not call our lint command on the few packages that have .css files.
  • It was not configured properly, just throwing an error when invoked on an actual .css file.

Also updated dependencies, mostly minor version updates

@matyasf matyasf self-assigned this Sep 30, 2024
@matyasf matyasf changed the title refactor(many): update dependecies part 1 refactor(many): update dependecies Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-03 11:31 UTC

@matyasf matyasf changed the title refactor(many): update dependecies Remove ui-stylelint-config, update dependecies Oct 1, 2024
Comment on lines +59 to +60
{null}
{false}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new TS version is clever and figures out that the part after && is never executed

@@ -52,10 +52,11 @@ export default {

// optimize svgs in place
runCommandSync('svgo', [
'-r',
'-f',
'--quiet',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will make bootstrap a bit less spammy

Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Copy link
Contributor

@HerrTopi HerrTopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

It was used to lint .css files, which is kinda useless by itself because we only have a few .css
files and most of them are autogenerated
@matyasf matyasf merged commit 99f8068 into master Oct 3, 2024
10 of 11 checks passed
@matyasf matyasf deleted the update_deps branch October 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants