chore: add older versions to gh pages deploy #1697
Conversation
|
joyenjoyer
force-pushed
the
gh_pages_deployment
branch
from
1b0e204
to
545f29d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -69,9 +69,12 @@ | |||
| // If we select the latest version from the dropdown, | |||
| // then navigate to the index (instructure.design/#currentHash). | |||
| // In every other case eg.: v6,v7 navigate to --> instructure.design/v6/#currentHash | |||
| const rootToAdd = window.location.origin.includes('github.io') | |||
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 9 days ago
To fix the problem, we need to replace the substring check with a more secure method of validating the host of the URL. We will use the URL constructor to parse the URL and then check the host directly. This ensures that the check is performed on the correct part of the URL and cannot be bypassed by embedding the allowed host in an unexpected location.
- Parse the URL using the
URLconstructor. - Check the
hostnameproperty of the parsed URL to determine if it matchesgithub.io.
| @@ -71,3 +71,4 @@ | ||
| // In every other case eg.: v6,v7 navigate to --> instructure.design/v6/#currentHash | ||
| const rootToAdd = window.location.origin.includes('github.io') | ||
| const url = new URL(window.location.href); | ||
| const rootToAdd = url.hostname === 'github.io' | ||
| ? '/instructure-ui' |
| const versionsData = await result.json() | ||
|
|
||
| return versionsData | ||
| let input = window.location.hostname.includes('github.io') |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
No description provided.