Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inst UI 4066 investigation integration of vitest for unit testing #1516

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Inst UI 4066 investigation integration of vitest for unit testing #1516

merged 1 commit into from
Jul 10, 2024

Conversation

git-nandor
Copy link
Contributor

No description provided.

@git-nandor git-nandor closed this May 15, 2024
@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch from 07ce784 to 2d59b0c Compare May 15, 2024 08:05
@git-nandor git-nandor reopened this May 15, 2024
@git-nandor git-nandor self-assigned this May 15, 2024
@git-nandor git-nandor marked this pull request as ready for review May 27, 2024 07:59
@balzss
Copy link
Contributor

balzss commented May 31, 2024

looks great, I think we should go forward with this

@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch 3 times, most recently from 8e00f75 to 7f1033c Compare June 12, 2024 09:04
@github-actions GitHub Actions
Copy link

Preview URL: https://1516--preview-instui.netlify.app

@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch 3 times, most recently from f0de943 to 7511b6f Compare June 14, 2024 08:18
@balzss
Copy link
Contributor

balzss commented Jun 14, 2024

I guess jest as a dependency could also be removed in this pr

@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch 3 times, most recently from 90e50e7 to ff2af07 Compare July 2, 2024 15:17
@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch from ff2af07 to 70c3989 Compare July 4, 2024 07:37
balzss
balzss requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like vitest is running in watch mode by default (but not in CI), would be nice to disabled that

@balzss
Copy link
Contributor

balzss commented Jul 5, 2024

also package-lock is not in synch with package.json, please update that

@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch from 018f682 to 17c0d2e Compare July 9, 2024 07:27
matyasf
matyasf requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-commands.md needs to be around the "npm run test" part, it still says that the tests are running in Chrome. otherwise good job!

@balzss balzss self-requested a review July 9, 2024 12:01
balzss
balzss approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch from 17c0d2e to 18eaa3e Compare July 10, 2024 09:32
@matyasf matyasf self-requested a review July 10, 2024 11:26
@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch from 18eaa3e to 3a87410 Compare July 10, 2024 14:26
@git-nandor git-nandor force-pushed the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch from 3a87410 to d3cd57b Compare July 10, 2024 14:54
@git-nandor git-nandor merged commit 517bab6 into master Jul 10, 2024
8 checks passed
@git-nandor git-nandor deleted the INSTUI-4066_investigation_integration_of_vitest_for_unit_testing branch July 10, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyenjoyer joyenjoyer joyenjoyer left review comments

@matyasf matyasf matyasf approved these changes

@balzss balzss balzss approved these changes

@HerrTopi HerrTopi Awaiting requested review from HerrTopi

Assignees

@git-nandor git-nandor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@git-nandor @balzss @matyasf @joyenjoyer