Skip to content

Commit

Permalink
refactor(many): remove unused dependencies, add missing ones
Browse files Browse the repository at this point in the history 
We had some packages which had missing dependencies (mainly shared-types), this might break stuff if
we change transitive dependencies
  • Loading branch information
@matyasf @balzss
matyasf authored and balzss committed Jun 6, 2024
1 parent 85765ae commit 23efdfc
Show file tree
Hide file tree
Showing 34 changed files with 39 additions and 95 deletions.
46 changes: 11 additions & 35 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions packages/__examples__/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,12 @@
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.24.5",
"@instructure/canvas-theme": "9.0.1",
"@instructure/command-utils": "9.0.1",
"@instructure/ui-babel-preset": "9.0.1",
"@instructure/ui-buttons": "9.0.1",
"@instructure/ui-i18n": "9.0.1",
"@instructure/ui-icons": "9.0.1",
"@instructure/ui-tooltip": "9.0.1",
"@instructure/ui-view": "9.0.1",
"@instructure/ui-webpack-config": "9.0.1",
"@instructure/uid": "9.0.1",
"@storybook/addons": "^7.6.19",
"@storybook/react": "^7.6.19",
"@storybook/theming": "^7.6.19",
Expand All @@ -54,9 +50,6 @@
"storybook": "^7.6.19",
"webpack": "^5.91.0"
},
"//dependency-comments": {
"globby": "since 12.0.0 globby is pure ESM, it cannot be require()'d"
},
"resolutions": {
"@storybook/react/webpack": "^5"
}
Expand Down
6 changes: 0 additions & 6 deletions packages/ui-a11y-content/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,9 @@
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.24.5",
"@instructure/console": "9.0.1",
"@instructure/emotion": "9.0.1",
"@instructure/shared-types": "9.0.1",
"@instructure/ui-dom-utils": "9.0.1",
"@instructure/ui-prop-types": "9.0.1",
"@instructure/ui-react-utils": "9.0.1",
"@instructure/ui-utils": "9.0.1",
"@instructure/uid": "9.0.1",
"keycode": "^2.2.1",
"prop-types": "^15.8.1"
},
"devDependencies": {
Expand Down
5 changes: 0 additions & 5 deletions packages/ui-a11y-content/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,9 @@
},
"include": ["src"],
"references": [
{ "path": "../console/tsconfig.build.json" },
{ "path": "../emotion/tsconfig.build.json" },
{ "path": "../shared-types/tsconfig.build.json" },
{ "path": "../ui-dom-utils/tsconfig.build.json" },
{ "path": "../ui-prop-types/tsconfig.build.json" },
{ "path": "../ui-react-utils/tsconfig.build.json" },
{ "path": "../ui-utils/tsconfig.build.json" },
{ "path": "../uid/tsconfig.build.json" },
{ "path": "../ui-babel-preset/tsconfig.build.json" },
{ "path": "../ui-test-utils/tsconfig.build.json" }
]
Expand Down
5 changes: 2 additions & 3 deletions packages/ui-a11y-utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,10 @@
"@instructure/console": "9.0.1",
"@instructure/ui-a11y-content": "9.0.1",
"@instructure/ui-dom-utils": "9.0.1",
"@instructure/shared-types": "9.0.1",
"@instructure/ui-react-utils": "9.0.1",
"@instructure/ui-testable": "9.0.1",
"@instructure/uid": "9.0.1",
"keycode": "^2.2.1",
"prop-types": "^15.8.1"
"keycode": "^2.2.1"
},
"devDependencies": {
"@instructure/ui-babel-preset": "9.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-a11y-utils/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
{ "path": "../ui-a11y-content/tsconfig.build.json" },
{ "path": "../ui-dom-utils/tsconfig.build.json" },
{ "path": "../ui-react-utils/tsconfig.build.json" },
{ "path": "../ui-testable/tsconfig.build.json" },
{ "path": "../uid/tsconfig.build.json" },
{ "path": "../ui-babel-preset/tsconfig.build.json" },
{ "path": "../ui-color-utils/tsconfig.build.json" },
{ "path": "../shared-types/tsconfig.build.json" },
{ "path": "../ui-test-utils/tsconfig.build.json" }
]
}
2 changes: 0 additions & 2 deletions packages/ui-alerts/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@
"@instructure/ui-motion": "9.0.1",
"@instructure/ui-react-utils": "9.0.1",
"@instructure/ui-themes": "9.0.1",
"@instructure/ui-utils": "9.0.1",
"@instructure/ui-view": "9.0.1",
"@instructure/uid": "9.0.1",
"keycode": "^2.2.1",
"prop-types": "^15.8.1"
},
Expand Down
4 changes: 1 addition & 3 deletions packages/ui-alerts/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
{ "path": "../ui-motion/tsconfig.build.json" },
{ "path": "../ui-react-utils/tsconfig.build.json" },
{ "path": "../ui-themes/tsconfig.build.json" },
{ "path": "../ui-utils/tsconfig.build.json" },
{ "path": "../ui-view/tsconfig.build.json" },
{ "path": "../uid/tsconfig.build.json" }
{ "path": "../ui-view/tsconfig.build.json" }
]
}
1 change: 0 additions & 1 deletion packages/ui-avatar/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.24.5",
"@instructure/console": "9.0.1",
"@instructure/emotion": "9.0.1",
"@instructure/shared-types": "9.0.1",
"@instructure/ui-icons": "9.0.1",
Expand Down
3 changes: 0 additions & 3 deletions packages/ui-avatar/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
},
"include": ["src"],
"references": [
{
"path": "../console/tsconfig.build.json"
},
{
"path": "../emotion/tsconfig.build.json"
},
Expand Down
2 changes: 0 additions & 2 deletions packages/ui-badge/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.24.5",
"@instructure/console": "9.0.1",
"@instructure/emotion": "9.0.1",
"@instructure/shared-types": "9.0.1",
"@instructure/ui-color-utils": "9.0.1",
"@instructure/ui-position": "9.0.1",
"@instructure/ui-react-utils": "9.0.1",
"@instructure/ui-testable": "9.0.1",
"@instructure/ui-utils": "9.0.1",
"@instructure/ui-view": "9.0.1",
"prop-types": "^15.8.1"
},
Expand Down
2 changes: 0 additions & 2 deletions packages/ui-badge/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
},
"include": ["src"],
"references": [
{ "path": "../console/tsconfig.build.json" },
{ "path": "../emotion/tsconfig.build.json" },
{ "path": "../shared-types/tsconfig.build.json" },
{ "path": "../ui-color-utils/tsconfig.build.json" },
Expand All @@ -18,7 +17,6 @@
{ "path": "../ui-babel-preset/tsconfig.build.json" },
{ "path": "../ui-test-utils/tsconfig.build.json" },
{ "path": "../ui-themes/tsconfig.build.json" },
{ "path": "../ui-utils/tsconfig.build.json" },
{ "path": "../ui-axe-check/tsconfig.build.json" }
]
}
1 change: 1 addition & 0 deletions packages/ui-buttons/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"@instructure/ui-color-utils": "9.0.1",
"@instructure/ui-dom-utils": "9.0.1",
"@instructure/ui-icons": "9.0.1",
"@instructure/ui-prop-types": "9.0.1",
"@instructure/ui-position": "9.0.1",
"@instructure/ui-react-utils": "9.0.1",
"@instructure/ui-testable": "9.0.1",
Expand Down
1 change: 1 addition & 0 deletions packages/ui-buttons/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
{ "path": "../ui-color-utils/tsconfig.build.json" },
{ "path": "../ui-dom-utils/tsconfig.build.json" },
{ "path": "../ui-icons/tsconfig.build.json" },
{ "path": "../ui-prop-types/tsconfig.build.json" },
{ "path": "../ui-position/tsconfig.build.json" },
{ "path": "../ui-react-utils/tsconfig.build.json" },
{ "path": "../ui-testable/tsconfig.build.json" },
Expand Down
1 change: 1 addition & 0 deletions packages/ui-date-input/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"@instructure/ui-prop-types": "9.0.1",
"@instructure/ui-react-utils": "9.0.1",
"@instructure/ui-selectable": "9.0.1",
"@instructure/shared-types": "9.0.1",
"@instructure/ui-testable": "9.0.1",
"@instructure/ui-text-input": "9.0.1",
"@instructure/ui-utils": "9.0.1",
Expand Down
3 changes: 3 additions & 0 deletions packages/ui-date-input/tsconfig.build.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@
{
"path": "../ui-selectable/tsconfig.build.json"
},
{
"path": "../shared-types/tsconfig.build.json"
},
{
"path": "../ui-testable/tsconfig.build.json"
},
Expand Down
Loading

0 comments on commit 23efdfc

Please sign in to comment.