-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Profile Settings and Advanced #3135
Conversation
…ponent, which still needs to be moved into the HorizonUI package.
… The updates are rejected
❌ XCTest failed: CoreTests/WKHTTPCookieStoreExtensionsTests/testDeleteAllCookies
❌ XCTest failed: TeacherTests/PostGradesPresenterTests/testAllGradesPosted
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Horizon/Horizon/Sources/Features/Account/Advanced/ProfileAdvancedViewModel.swift
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/Account/Profile/Common/View/ProfileBody.swift
Outdated
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/Account/Profile/Common/View/SavingButton.swift
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/Account/Profile/Domain/UpdateUserProfileInteractor.swift
Outdated
Show resolved
Hide resolved
...ges/HorizonUI/Sources/HorizonUI/Sources/Components/SingleSelect/HorizonUI.SingleSelect.swift
Outdated
Show resolved
Hide resolved
...ges/HorizonUI/Sources/HorizonUI/Sources/Components/SingleSelect/HorizonUI.SingleSelect.swift
Outdated
Show resolved
Hide resolved
...ges/HorizonUI/Sources/HorizonUI/Sources/Components/SingleSelect/HorizonUI.SingleSelect.swift
Outdated
Show resolved
Hide resolved
packages/HorizonUI/Sources/HorizonUI/Sources/Components/TextInput/HorizonUI.TextInput.swift
Outdated
Show resolved
Hide resolved
packages/HorizonUI/Sources/HorizonUI/Sources/Components/TextInput/HorizonUI.TextInput.swift
Outdated
Show resolved
Hide resolved
@szabinst How about this? Instead of an opacity fade, I animate the height. I think it looks nice. Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-02-12.at.10.50.06.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work! It's working fine, but I hope that in the next big task, you try to divide it into smaller tasks and smaller PRs.
1-Please add your new Storybook component, like TextField, to the Design System tab as a reference for us in the future, as we have done.
2- In the Advanced settings, when I open the time zone dropdown list, I can't dismiss it until I select a time. The keyboard also stays open. Please make it so that tapping outside closes both the dropdown and the keyboard.
3- Now in the advanced setting i got an error at log but can't see any alert for the error, please check the error handling
{"status":"unauthorized","errors":[{"message":"user not authorised to perform that action"}]} keyNotFound(CodingKeys(stringValue: "id", intValue: nil), Swift.DecodingError.Context(codingPath: [], debugDescription: "No value associated with key CodingKeys(stringValue: "id", intValue: nil) ("id").", underlyingError: nil))
4- In the profile too, got an error at log can't see any alert for error & check to dismiss the keyboard when tap outside.
{"name":"Ahmed Naguib","id":"1306","created_at":"2024-08-09T02:11:51+02:00","sortable_name":"Naguib, Ahmed","short_name":"Ahmed Naguib ","sis_user_id":"student","integration_id":"password","sis_import_id":null,"login_id":"Ahmed.Naguib","avatar_url":"https://horizon.cd.instructure.com/images/messages/avatar-50.png","avatar_state":"none","email":"[email protected]","locale":null,"time_zone":"Rome"} typeMismatch(Swift.Dictionary<Swift.String, Any>, Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "time_zone", intValue: nil)], debugDescription: "Expected to decode Dictionary<String, Any> but found a string instead.", underlyingError: nil))
Horizon/Horizon/Sources/Features/Account/Advanced/ProfileAdvancedView.swift
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/Account/Advanced/ProfileAdvancedViewModel.swift
Outdated
Show resolved
Hide resolved
|
||
init(api: API = AppEnvironment.shared.api) { | ||
self.api = api | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API not used, please remove it
...rces/HorizonUI/Sources/Components/Inputs/SingleSelect/HorizonUI.SingleSelect.Storybook.swift
Show resolved
Hide resolved
...es/HorizonUI/Sources/HorizonUI/Sources/Components/Inputs/TextInput/HorizonUI.TextInput.swift
Show resolved
Hide resolved
...es/HorizonUI/Sources/HorizonUI/Sources/Components/Inputs/TextInput/HorizonUI.TextInput.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. The animation is much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes
[ignore-commit-lint]