Open native speedgrader from web discussion #3131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-17942 affects: Teacher release note: SpeedGrader now correctly opens from graded discussions. test plan: - Create a graded discussion. - Post a comment as a student and as a non-student user. - Open the discussion from the teacher app. - Open SpeedGrader from the main post of the discussion. - SpeedGrader should open. - Open SpeedGrader from a post of a student. - SpeedGrader should open focused on that student. - Open SpeedGrader from a post of a teacher. - SpeedGrader should open with an error.
…from-web-discussion
vargaat
requested review from
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
Teacher Build QR Code: |
| @@ -21,6 +21,7 @@ import UIKit | |||
| import Core | |||
|
|
|||
| class SpeedGraderViewController: ScreenViewTrackableViewController, PagesViewControllerDataSource { | |||
| static let AllUsersUserID = "speedgrader" | |||
There was a problem hiding this comment.
Should it be private ?
There was a problem hiding this comment.
I'm using it in tests so it can't be private but I added the internal modifier to it to make this usage explicit.
|
QA +1 Tested on iPhone, iOS 18.2.0, Teacher app. |
suhaibabsi-inst
approved these changes
Feb 12, 2025
|
Found this issue. When speedgrader is opened and then we put the app into background and then back to foreground and then we tap on done button, the app crashes. RPReplay_Final1739361305.MP4 |
ndrsszsz
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-17942
affects: Teacher
release note: SpeedGrader now correctly opens from graded discussions.
test plan:
Screenshots
Checklist