use the latest handler passed in by the props #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the shouldComponentUpdate only checks content and config, if you change an event handler, the component will still be using the previous old handler. A simple fix would be to just always get the latest handler from the props to call instead of using the one stored in the closure. Just a suggestion, but it is a bug that I had to address in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the shouldComponentUpdate only checks props.content and props.config, if you change an event handler, the component will still be using the previous handler. A simple fix would be to just always get the latest handler from the props to call instead of using the one stored in the closure.
Just a suggestion, but it is a bug that I had to address in production.