Add ability to view randomly selected chunks #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anastas Stoyanovsky <[email protected]>
anastasds
requested review from
alimaredia,
fabianofranz,
iamemilio,
alinaryan,
JustinXHale and
khaledsulayman
as code owners
Co-authored-by: Fabiano Franz <[email protected]> Signed-off-by: Anastas Stoyanovsky <[email protected]>
alimaredia
reviewed
Jun 11, 2025
| "To view the chunks, run through the following cell. As you can see the document is broken into small pieces with metadata about the chunk based on the document's format" | ||
| "To view a random sample of the generated chunks, run through the following cell. Re-run the cell to see another random sample. If there are chunking issues, try different conversion and/or chunking configurations.\n", | ||
| "\n", | ||
| "As you can see, the document is broken into small pieces with metadata about the chunk based on the document's format." |
There was a problem hiding this comment.
You mention the metadata here being in the chunk. It would be nice to have an example or two of chunks within the documentation and point out that metadata. Also we know table chunks can be hard to parse upon first glance. I think showing the user an example just to prepare them for seeing a chunk like that might be helpful
There was a problem hiding this comment.
I think having an example chunk could either be helpful or confusing here. What if their chunk isn't similar? Is that bad or good?
|
Closing in favor of #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.