Skip to content

Don't check pull_request targets #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Jun 23, 2025

These do not have access to secrets.

Signed-off-by: Ihar Hrachyshka [email protected]

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been added and/or updated, if applicable.
  • Unit tests have been added and/or updated. (If this is not applicable, please provide a justification.)
  • Integration testing has been performed, if applicable

Description of this Change

@booxter
Copy link
Contributor Author

booxter commented Jun 23, 2025

See https://github.com/instructlab/training/actions/runs/15788246349/job/44509172626?pr=622 for example of an innocent job failing. AFAIU only pull_request_target has access to secrets.

@booxter
Copy link
Contributor Author

booxter commented Jun 23, 2025

This should solve failure in instructlab/training#622

@mergify mergify bot added the ci-failure label Jun 23, 2025
These do not have access to secrets.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter booxter force-pushed the dont-check-pull-request branch from 3b6972b to 2b9d989 Compare June 23, 2025 21:20
@mergify mergify bot removed the ci-failure label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant