-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collect shared logic for blob storage and minio #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little comment on this but not a blocker. Did you extract this code from any service (because another one needs to use it) or is it something several services will use in the future?
I think |
Yeah, my question was if this had been copied from somewhere (e.g. |
🤖 I have created a release *beep* *boop* --- ## [0.6.0-alpha](v0.5.0-alpha...v0.6.0-alpha) (2024-12-13) ### Features * collect shared logic for blob storage and minio ([#27](#27)) ([36280f1](36280f1)) * **minio:** add expiry tag and rule ([#23](#23)) ([6659d46](6659d46)) ### Bug Fixes * **minio:** remove default bucket lifecycle rule ([#30](#30)) ([890bb31](890bb31)) * **minio:** set life cycle config on existing bucket ([#25](#25)) ([3b853d0](3b853d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Because
This commit
Note