Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect shared logic for blob storage and minio #27

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

chuang8511
Copy link
Contributor

@chuang8511 chuang8511 commented Nov 14, 2024

Because

  • blob storage will be used in different service

This commit

  • collect get and upload data function

Note

  • For minio pkg, the current pkg is not fit with the current design of blob storage. We will refactor that part with run logging.
  • We will need to add the test code

Copy link

linear bot commented Nov 14, 2024

Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little comment on this but not a blocker. Did you extract this code from any service (because another one needs to use it) or is it something several services will use in the future?

blobstorage/blobstorage.go Outdated Show resolved Hide resolved
@chuang8511
Copy link
Contributor Author

Did you extract this code from any service (because another one needs to use it) or is it something several services will use in the future?

I think UploadFile will be used in model-backend & pipeline-backend. So, I extracted it.
Is this what you are asking?

@jvallesm
Copy link
Collaborator

Did you extract this code from any service (because another one needs to use it) or is it something several services will use in the future?

I think UploadFile will be used in model-backend & pipeline-backend. So, I extracted it. Is this what you are asking?

Yeah, my question was if this had been copied from somewhere (e.g. api-gateway plugin) or if it was new code. Basically I wanted to know which will be the current and future clients for this code. Thanks for the answer, it's clear 👍

@donch1989 donch1989 merged commit 36280f1 into main Nov 19, 2024
5 checks passed
@donch1989 donch1989 deleted the chunhao/ins-6780-collect-shared-pkg branch November 19, 2024 00:46
jvallesm pushed a commit that referenced this pull request Dec 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.0-alpha](v0.5.0-alpha...v0.6.0-alpha)
(2024-12-13)


### Features

* collect shared logic for blob storage and minio
([#27](#27))
([36280f1](36280f1))
* **minio:** add expiry tag and rule
([#23](#23))
([6659d46](6659d46))


### Bug Fixes

* **minio:** remove default bucket lifecycle rule
([#30](#30))
([890bb31](890bb31))
* **minio:** set life cycle config on existing bucket
([#25](#25))
([3b853d0](3b853d0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants