-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component,instillmodel): migrate instill model component #777
base: main
Are you sure you want to change the base?
Conversation
Hi @jvallesm Want to clarify if this test code aligns what you think like we discussed before. |
Yes! That's the approach, exactly. Kudos, as Perhaps if we have more use cases for this we can build later a wrapper to simplify the process of creating the server and defining its responses. One first step would be adding the mock to the generated code in |
…sign and add standardised task chat input & output
73f96e4
to
a6f43f4
Compare
@donch1989 |
Yes, I think we can use that for now and refactor it later. |
Do you have time to review it? Or can we merge it after I rebase it? |
And, for the document part, we will need @GeorgeWilliamStrong to review it. Thank you. |
Because
This commit
Note
Read()
&Write()
, we will phase them out with Instill Model together, which we will discuss in the future plan.