Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ray): support multi-gpu suffix #714

Merged
merged 1 commit into from
Dec 10, 2024
Merged

feat(ray): support multi-gpu suffix #714

merged 1 commit into from
Dec 10, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Dec 10, 2024

Because

  • Allow ray to request for multi-gpu capable nodes

This commit

  • support multi-gpu suffix

Copy link

linear bot commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 151 lines in your changes missing coverage. Please review.

Project coverage is 4.71%. Comparing base (f519c82) to head (22a8ec2).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mock/ray_mock.gen.go 0.00% 91 Missing ⚠️
pkg/ray/ray.go 0.00% 41 Missing ⚠️
pkg/ray/util.go 0.00% 13 Missing ⚠️
pkg/service/service.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #714      +/-   ##
========================================
+ Coverage   3.41%   4.71%   +1.30%     
========================================
  Files         64      62       -2     
  Lines      13780   18737    +4957     
========================================
+ Hits         470     884     +414     
- Misses     13263   17691    +4428     
- Partials      47     162     +115     
Flag Coverage Δ
unittests 4.71% <0.00%> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit bfc442d into main Dec 10, 2024
14 checks passed
@heiruwu heiruwu deleted the heiru/INS-7111 branch December 10, 2024 10:31
heiruwu pushed a commit that referenced this pull request Dec 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.34.0-alpha](v0.33.1-alpha...v0.34.0-alpha)
(2024-12-16)


### Features

* **handler:** add title for region hardware
([#718](#718))
([c71bb75](c71bb75))
* **ray:** support multi-gpu suffix
([#714](#714))
([bfc442d](bfc442d))
* **ray:** utilize redis as deployment config cache
([#722](#722))
([da20daf](da20daf))


### Bug Fixes

* **ray:** fix missing deployment configs
([#717](#717))
([9d20344](9d20344))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants