fix(ci): use xk6-sql driver and pin down versions #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
requested review from
Sarthak-instill,
donch1989 and
heiruwu
as code owners
jvallesm
commented
Nov 26, 2024
| - name: Install k6 | ||
| run: | | ||
| go install go.k6.io/xk6/cmd/xk6@v${{ env.XK6_VERSION }} | ||
| xk6 build v${{ env.K6_VERSION }} --with github.com/grafana/[email protected] && sudo cp k6 /usr/bin | ||
| xk6 build v${{ env.K6_VERSION }} \ |
There was a problem hiding this comment.
❓ @donch1989 do the make-* workflows need this step? I don't see where they are referenced and the workflow itself doesn't need k6
donch1989
pushed a commit
that referenced
this pull request
Dec 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.47.0-beta](v0.46.0-beta...v0.47.0-beta) (2024-12-03) ### Bug Fixes * **ci:** use xk6-sql driver and pin down versions ([#1159](#1159)) ([321a041](321a041)) ### Miscellaneous Chores * release v0.47.0-beta ([da6568e](da6568e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
xk6-sqlhas a new release with breaking changes.This commit