ci: updated aws Lambda base image to node:20

[aryamohanan]

We already dropped support for Node.js 16 aws lambda runtime in the last major release, we missed to update the dockerfile.

Updated the base image in the Dockerfile to public.ecr.aws/lambda/nodejs:22 to align with the latest Node.js version for AWS Lambda.

[kirrg001]

For what are we using this Dockerfile?
And where do we reference this file?

[aryamohanan]

For what are we using this Dockerfile? And where do we reference this file?

In my understanding, this docker image is the base image used when building the image for aws lambda, https://github.com/instana/nodejs/blob/main/packages/aws-lambda/layer/bin/publish-layer.sh#L376

[kirrg001]

Yeah I saw this too, but I wasn't sure. But I can see a cd .., which navigates up to the Dockerfile 👍

I think we should pass the Node version as an argument.

docker build --build-arg NODEJS_VERSION=$NODEJS_VERSION . -t "$DOCKER_IMAGE_NAME:$VERSION"

Dockerfile

# see publish-layer.sh
ARG NODEJS_VERSION
FROM public.ecr.aws/lambda/nodejs:${NODEJS_VERSION}

This NODEJS_VERSION needs to be the version which is supported by our layer

--compatible-runtimes nodejs18.x nodejs20.x nodejs22.x \

Either we use our development version or define the version in the publish-layer script.

---

In general: It seems there is a poor support for Lambda layers in a Docker container. Because we only build the image with a specific AWS Lambda Node.js version always for the latest version. Our docs may need to make that clear. See https://www.ibm.com/docs/de/instana-observability/1.0.293?topic=lambda-aws-native-tracing-nodejs#instana-lambda-layer-for-container-based-functions

[kirrg001]

I guess its good to do

supportedVersions="--compatible-runtimes nodejs18.x nodejs20.x nodejs22.x"
dockerNodeVersion="grab the lowest or highest supported node version from $supportedVersions"

[abhilash-sivan]

+1 for using development version

[aryamohanan]

As recommended, I have added the development version for the Docker image. Since v18 has already reached its end of life, and v22 officially added AWS support in November 2024, this update aligns with the current standards. Please share your thoughts

[abhilash-sivan]

Can we define the development version in a single constants file and reference it across all packages?
This would help improve maintainability since the version is repeated in multiple places.

P.S.: This might be out of scope for this PR.

[aryamohanan]

Good suggestion, we can certainly consider doing that.

[kirrg001]

Any reason we are not using

NVMRC_PATH="$ROOT_DIR/.nvmrc"
NODEJS_VERSION=$(cat "$NVMRC_PATH")

?

[aryamohanan]

That's a good suggestion—I hadn't thought of it that way. I was only considering a generic file where we could define the version and use it everywhere. But reading from the .nvmrc file makes sense, especially since we're using the development version of Node for the images.

[kirrg001]

pre-approving