refactor: added options pattern for backend connector init #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
commented
Feb 26, 2025
| propagateErrorsUpstream = _propagateErrorsUpstream == null ? false : _propagateErrorsUpstream; | ||
| defaultTimeout = _defaultTimeout == null ? defaultTimeout : _defaultTimeout; | ||
| useLambdaExtension = _useLambdaExtension; | ||
| backendTimeout = defaultTimeout; |
There was a problem hiding this comment.
68-72 removed because we work with defaults now.
| } | ||
| } | ||
|
|
||
| if (identityProvider) { | ||
| hostHeader = identityProvider.getHostHeader(); | ||
| if (options.identityProvider) { |
There was a problem hiding this comment.
Suggestion:
Can we optimize this to:
if (options.identityProvider) {
hostHeader = options.identityProvider.getHostHeader() || 'nodejs-serverless';
} else {
hostHeader = 'nodejs-serverless';
}
Or should we maintain the existing logic to allow hostHeader = '' if getHostHeader() returns an empty string?
There was a problem hiding this comment.
Agree. But I have not touched this code. Feel free to raise a new PR to optimize the condition 👍
kirrg001
force-pushed
the
refactor-backend-conn
branch
from
3f9da78 to
52abf31
Compare
aryamohanan
pushed a commit
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1315