Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to denylist #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

professor
Copy link

No description provided.

It's 2024, we should have fixed this awhile ago
@professor
Copy link
Author

I'm curious if you consider this to be a breaking change. If so, do you have any suggestions on how to roll out this PR?

@professor
Copy link
Author

@mlarraz I'm curious if there is any interest in merging this PR.

If yes, I'm willing to do the work to deprecate the remaining references to blacklist and whitelist. Here's an example of work that I started ... (and I'm willing to finish)

module Makara
  class ConfigParser
    DEFAULTS = {
      primary_ttl: 5,
      deny_list_duration: 30,
      sticky: true
    }

    DEPRECATED_KEYS = {
      blacklist_duration:   :deny_list_duration,
      ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant