Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arity bug with owner method inline with other pool overrides #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ridiculous
Copy link

@ridiculous ridiculous commented Mar 28, 2024

Hey, this should fix kind of an obscure error coming from the connection wrapper when an error condition is met. For example, in my case, this error is thrown when there is a deadlock and the transaction is rolled back:

# ArgumentError
# wrong number of arguments (given 1, expected 0)
# gems/makara-0.5.1/lib/makara/connection_wrapper.rb:296 owner

Updates the owner method to conform to other methods in the abstract adapter, which generally ignore any arguments given, but all accept a splat of args.

In case it's helpful, I ran into this problem on Rails 6.1.7.3 using the latest published version of this gem 0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant