Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Digest::MD5 with OpenSSL::Digest::SHA256 for FIPS 140-2 compliance #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saghaulor
Copy link

  • The Ruby Digest class is not FIPS 140-2 compliant. When running in FIPS mode,
    calling Digest results in a segfault. Moreover, MD5 is not FIPS compliant and
    cannot be used in FIPS mode. Even when using OpenSSL::Digest::MD5 an exception
    will be raised.
  • Remove unused require of 'digest/md5' from the context.rb

…iance

- The Ruby Digest class is not FIPS 140-2 compliant. When running in FIPS mode,
  calling Digest results in a segfault. Moreover, MD5 is not FIPS compliant and
  cannot be used in FIPS mode. Even when using OpenSSL::Digest::MD5 an exception
  will be raised.
- Remove unused require of 'digest/md5' from the context.rb
@cwjenkins
Copy link

@mlarraz any issues with the above? I'm hitting this now.
Could do a conditional check in the event the gem isn't in an environment with openssl, but if you don't see any issues using a different digest for ID then I can patch until something is handled here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants