Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage (pt5). #392

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Increase code coverage (pt5). #392

merged 1 commit into from
Sep 18, 2024

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Sep 18, 2024

  • Created test-utils/android module that will replace instacart-android-tests
  • Added ActivityStoreContextTest to fill some gaps in coverage

@carrotkite
Copy link

carrotkite commented Sep 18, 2024 •
edited
Loading

JaCoCo Code Coverage 97.13% ✅

Class Covered Meta Status
com/instacart/testutils/android/TestActivity 100% 0% ✅
com/instacart/testutils/android/TestFragmentActivity 100% 0% ✅
com/instacart/formula/android/internal/ActivityStoreContextImpl 100% 0% ✅

Generated by 🚫 Danger

@Laimiux Laimiux force-pushed the laimonas/increase-coverage-pt5 branch from 60916ea to 6fb4fbd Compare September 18, 2024 14:34
@Laimiux Laimiux merged commit 94da8d2 into master Sep 18, 2024
4 checks passed
@Laimiux Laimiux deleted the laimonas/increase-coverage-pt5 branch September 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbezverhni alexanderbezverhni alexanderbezverhni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laimiux @carrotkite @alexanderbezverhni