Adding simple examples to README.md #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
force-pushed
the
laimonas/update-readme
branch
from
a32add9
to
0130ff7
Compare
JaCoCo Code Coverage 80.64% ✅
Generated by 🚫 Danger |
| val decrementButton: Button = ... | ||
|
|
||
| // We convert Formula instance to RxJava observable. | ||
| val counterOutput: Observable<CounterFormula.Output> = CounterFormula().toObservable() |
There was a problem hiding this comment.
I wonder if we can show the example without using RxJava. Possible? Or maybe this should switch to Flow, might be more familiar to Android devs now.
There was a problem hiding this comment.
Added Flow example as well
Laimiux
force-pushed
the
laimonas/update-readme
branch
from
0130ff7
to
2fff920
Compare
Jawnnypoo
reviewed
Jun 29, 2022
| RxAction.fromObservable { repository.getCounterState() }.onEvent { currentCount -> | ||
| val newState = state.copy(currentCount = currentCount) | ||
| transition(newState) | ||
| } |
There was a problem hiding this comment.
Is there a way to use Flow here as well yet? I don't think we support it yet, but if we do, maybe we could add that example too.
There was a problem hiding this comment.
Yes, though I'm not yet sure how to best incorporate in in examples as there is RxJava as well. I will think about it more
Jawnnypoo
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I'm adding simple, but full examples to README.md. The goal is to show how Formula looks without getting too deep into details and best practices.