Add nysiis python 3 support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micha Moskovic <[email protected]>
Signed-off-by: Micha Moskovic <[email protected]>
Signed-off-by: Micha Moskovic <[email protected]>
Signed-off-by: Micha Moskovic <[email protected]>
michamos
force-pushed
the
add-nysiis-py3
branch
from
269fbb5
to
80bcf6e
Compare
pazembrz
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several algorithms can be used for phonetic blocking. The fuzzy library provides all of them, but has a bug in v1.2.* (see yougov/fuzzy#14) that prevents soundex from working correctly. Unfortunately, that's the only version compatible with Python 3. Previously, version 1.1 was used on Python 2 and an alternative implementation of double metaphone was used on Python 3, so soundex and NYSIIS were not available. Now we install version 1.1 on Python 2 and 1.2.* on Python 3, resulting in NYSIIS being always available also (this happens to be the algorithm giving the best results).
To summarize
Before:
After: