Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled #59

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Fix scheduled #59

merged 6 commits into from
Oct 14, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Oct 9, 2024

fix verdepcheck tests
rhub continue to fail - I opened a separate issue in rhub org to solve it

@pawelru pawelru marked this pull request as ready for review October 10, 2024 09:12
@pawelru pawelru added the core label Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-281
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         295     294  0.34%    13-510, 529-673
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            66      52  21.21%   3-23, 36-104
TOTAL                               757     689  8.98%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d53d77c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Unit Tests Summary

 1 files   4 suites   1s ⏱️
45 tests 15 ✅ 30 💤 0 ❌
98 runs  67 ✅ 31 💤 0 ❌

Results for commit d53d77c.

♻️ This comment has been updated with latest results.

@averissimo
Copy link
Contributor

averissimo commented Oct 11, 2024

@pawelru do you want to wait until rhub issue is resolved or can I approve this PR?

@pawelru
Copy link
Contributor Author

pawelru commented Oct 11, 2024

That has just been merged and released. Let me trigger another run now

@averissimo
Copy link
Contributor

I noticed that and I rerun the last run. The problem seems fixed, although there are some platforms that fail

https://github.com/insightsengineering/verdepcheck/actions/runs/11290686165/job/31412439902

image

@pawelru
Copy link
Contributor Author

pawelru commented Oct 11, 2024

Yeah. Let me do that next week. Converting this to draft.

@pawelru pawelru disabled auto-merge October 11, 2024 14:14
@pawelru pawelru marked this pull request as draft October 11, 2024 14:14
@pawelru pawelru marked this pull request as ready for review October 14, 2024 10:32
@pawelru
Copy link
Contributor Author

pawelru commented Oct 14, 2024

@pawelru pawelru merged commit 30e7c99 into main Oct 14, 2024
75 checks passed
@pawelru pawelru deleted the fix_scheduled branch October 14, 2024 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants