Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using remotes before remotes is installed #67

Closed
wants to merge 7 commits into from
Closed

Conversation

epijim
Copy link
Contributor

@epijim epijim commented Dec 29, 2023

Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@epijim epijim marked this pull request as draft December 30, 2023 08:01
@epijim
Copy link
Contributor Author

epijim commented Dec 30, 2023

Slowly finding more :) issues, will move to draft sorry @cicdguy

so far:

  • remotes was called before installed
  • we get API rate limiting on devtools::install_github. I see we are passing through a github pat, but maybe repo tokens aren't that great. switched to install from git to bypass the github API
  • now ran into devtools being missing- which is weird, will see why

Signed-off-by: James Black <[email protected]>
Signed-off-by: James Black <[email protected]>
Signed-off-by: James Black <[email protected]>
@@ -1,14 +1,17 @@
#!/usr/bin/env Rscript

# Install remotes
install.packages("remotes")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that pak is more efficient and will eventually replace remotes. What do you think about swapping out remotes with pak?

Copy link

CLA Assistant Lite bot:
🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (cicdguy)[https://github.com/cicdguy]
@epijim
You can retrigger this bot by commenting recheck in this Pull Request

@cicdguy cicdguy closed this Aug 27, 2024
@cicdguy cicdguy deleted the remotes-missing branch August 27, 2024 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants