-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grob wrapping final #1305
fix grob wrapping final #1305
Conversation
Unit Tests Summary 1 files 83 suites 1m 16s ⏱️ Results for commit cc0c161. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit bf9e148 ♻️ This comment has been updated with latest results. |
On ocean I do not get the same mismatch (4.3.3). Could it be different grid version?? |
Code Coverage Summary
Diff against main
Results for commit: cc0c161 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping of title in my package now works as expected. thank you.
Fixes #1287
I hope this is a wrap (:D). @BFalquet could take a look if it works on your side? Result may be numerically different but this is the real solution to the issue.
On another note, we need to consider uniforming
\\n
to\n
if it happens. I now know it is not always assumed the same and we have mixed behavior around the packages. I will check this for {rtables}. I was able to break wrapping by doing this.