Skip to content

Close 1089 use title case in default module label #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+2 −2
Open

Close 1089 use title case in default module label #1459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
20c1648
# 1089 Use title case for label="Report Preview"
jimrothstein Jan 22, 2025
b755b0b
# 1089 use title case for label in default_module
jimrothstein Jan 22, 2025
b7d5e69
Delete teal.Rproj
jimrothstein Jan 22, 2025
dcf5630
restore teal.Rproj
jimrothstein Jan 22, 2025
c77c48e
Merge branch '1089_use_title_case_in_default_module_label' of github.…
jimrothstein Jan 22, 2025
e12aa7f
attempting to restore teal.Rproj
jimrothstein Jan 22, 2025
6d2696d
Merge branch 'main' into 1089_use_title_case_in_default_module_label
llrs-roche Jan 23, 2025
5f19064
# 1089 fix test-report_previewer_module (use subject case)
jimrothstein Jan 23, 2025
58b733c
Merge branch 'main' into 1089_use_title_case_in_default_module_label
jimrothstein Jan 23, 2025
4fdfc1d
Merge branch 'main' into 1089_use_title_case_in_default_module_label
m7pr Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/reporter_previewer_module.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#'
#' @export
#'
reporter_previewer_module <- function(label = "Report previewer", server_args = list()) {
reporter_previewer_module <- function(label = "Report Previewer", server_args = list()) {
checkmate::assert_string(label)
checkmate::assert_list(server_args, names = "named")
checkmate::assert_true(all(names(server_args) %in% names(formals(teal.reporter::reporter_previewer_srv))))
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-report_previewer_module.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ testthat::test_that("report_previewer_module throws no error and stores label if

testthat::test_that("report_previewer_module default label is Report previewer ", {
r_p_m <- reporter_previewer_module()
testthat::expect_equal(r_p_m$label, "Report previewer")
testthat::expect_equal(r_p_m$label, "Report Previewer")
})

testthat::test_that(
Expand Down
Loading